readthedocs / blog

Read the Docs blog
https://blog.readthedocs.com
17 stars 56 forks source link

Build updates! #188

Closed benjaoming closed 1 year ago

benjaoming commented 1 year ago

This update also contains #169

Before:

image

After:

image

benjaoming commented 1 year ago

What this PR mainly changes is margins, but it also re-aligns "Recent posts" with contents below it, which I think is nicer for the eye.

I've opened https://github.com/readthedocs/blog/issues/191 to re-address margins.

benjaoming commented 1 year ago

I went back to very old blog posts and they still look good:

https://readthedocs-blog--188.org.readthedocs.build/new-theme-read-the-docs/ https://readthedocs-blog--188.org.readthedocs.build/read-the-docs-2013-stats/

...however, I found an issue with unorderd lists that are missing bullets. Probably a DOM change.

Adding more styles...

benjaoming commented 1 year ago

These are some good exercises for understanding what effort went into maintaining sphinx-theme-rtd :smiling_face_with_tear:

benjaoming commented 1 year ago

I've been clicking around on a lot of blog posts now and stopped noticing things that look wrong.

So I think we're good to ship this.

It's supporting docutils 0.17 btw.

agjohnson commented 1 year ago

Just noting that we don't plan to continue using our blog here. Our blog will be contained in our website repository, so spending much time here fixing things up is not a priority.

We don't have a timeframe, and need to consider if/how we port content:

https://github.com/readthedocs/site-community/issues/33

benjaoming commented 1 year ago

Ah yes, that's much better than the current blog. I wasn't aware. I'll wrap up the footnotes issue :+1:

Love the issue description over in https://github.com/readthedocs/site-community/issues/33 :heart:

benjaoming commented 1 year ago

Replaced the floating CSS in footnotes with display: table, looks fine in Chrome and Firefox.

image