readthedocs / doc-diff

Read the Docs documentation visual diff
0 stars 0 forks source link

Changes default value of `root_selector` #4

Open stsewd opened 2 years ago

stsewd commented 2 years ago

div.document[role='main'] is very sphinx specific (and more actually specific to the base theme), furo for example doesn't follow this convention, nor does mkdocs.

I propose default this to just [role='main'], and maybe make this a list, with [role=main], main (the tag). We do this for our version banner for example https://github.com/readthedocs/readthedocs.org/blob/587d6c26702179d9ec1d35e3a1c7fc2baa728511/readthedocs/core/static-src/core/js/doc-embed/version-compare.js#L25-L25.

humitos commented 1 year ago

Related to https://github.com/readthedocs/readthedocs-client/issues/13