readthedocs / ethicalads.io

This repository contains the public marketing website for EthicalAds. The ad server is in the ethical-ad-server repository.
https://www.ethicalads.io/
36 stars 13 forks source link

Make the testimonials into a carousel #441

Closed davidfischer closed 2 months ago

davidfischer commented 2 months ago

The testimonials are in a carousel. There's a bunch of options but I made a few choices:

Before I start refactoring which testimonials to show, I wanted to get some feedback on this so far.

Screenshot

Screenshot from 2024-07-17 15-38-55

ericholscher commented 2 months ago

This seems like a reasonable approach. It lets us highlight the "best" one, and folks can scroll around if they want to see more. :+1:

I have it autoscrolling with the default 3s interval (we can force users to scroll manually or autoscroll at a different interval)

I'd probably increase this, or just make it manual scroll?

davidfischer commented 2 months ago

I'd probably increase this, or just make it manual scroll?

I just tested this with 1.5s and it was way too fast. However, I'll push a commit with the variable so we can customize it later if we want to.

ericholscher commented 2 months ago

I meant slower, not faster. But I think manual is probably the best option for now, since auto-advancing is pretty annoying if you're actually trying to read it.

davidfischer commented 2 months ago

I did a PR to make it manually scroll: https://github.com/readthedocs/ethicalads.io/pull/444