Add test for Knockout semanticui data binding

readthedocs / ext-theme

Read the Docs drop in replacement site templates

2 stars 2 forks source link

Add test for Knockout semanticui data binding #215

Closed agjohnson closed 1 year ago

agjohnson commented 1 year ago

This confirms that the custom binding for SUI modules works as expected by inspecting the element and confirming it seems to have had our logic and the jQuery SUI plugin logic applied to it.

This found a small bug with the binding code itself. I only tested dropdown for now, I'm not sure if it's worth testing anything too deeply yet.

agjohnson commented 1 year ago

I'll treat the test for jsonInit handling as a separate change, that's a great test to have.

[x] Add test for exception handling on bad JSON data to the jsonInit (and friends) bindings

agjohnson commented 1 year ago

Test and error handling added here:

https://github.com/readthedocs/ext-theme/pull/221