Add missing notification template blocks for user, project, organization notifications

readthedocs / ext-theme

Read the Docs drop in replacement site templates

2 stars 2 forks source link

Add missing notification template blocks for user, project, organization notifications #260

Closed agjohnson closed 8 months ago

agjohnson commented 8 months ago

From the deploy today, it seems these were not ported to the new dashboard.

humitos commented 8 months ago

Template blocks on old dashboard that we need to migrate to ext-theme:

User: https://github.com/readthedocs/readthedocs.org/blob/4a864c37496657d767bafd254a723bd18a2fa242/readthedocs/templates/base.html#L106-L119
Project: https://github.com/readthedocs/readthedocs.org/blob/4a864c37496657d767bafd254a723bd18a2fa242/readthedocs/templates/core/project_bar_base.html#L32-L41
Organization: ??? -- I think this was not implemented there.

humitos commented 8 months ago

Organization: ??? -- I think this was not implemented there.

I implemented this at https://github.com/readthedocs/readthedocs.org/pull/11023

agjohnson commented 8 months ago

We might have missed opening an issue for the organization notifications, I remember discussing it at some point.

For notifications for user/project/orgs on the new dashboard, you can copy the previous template HTML structure for the message-extends messages. I believe this was removed in that last PR.