search

readthedocs / ext-theme

Read the Docs drop in replacement site templates
2 stars 2 forks source link

CI: add pre-commit checks in CI #268

Closed agjohnson closed 6 months ago

agjohnson commented 8 months ago

I thought this was added, but it isn't currently running. The pieces to make this work are all in other repositories already, but I know pre-commit at least needs to be configured to run against a commit instead of the staged work.

Namely, we seem to be missing the linting passes with djhtml, but there are others that could be triggered through pre-commit too, like prettier.

cc @humitos you might already know exactly what needs to be added here, this is probably a quick addition for you if you get a chance before I do.

agjohnson commented 6 months ago

@humitos you've mentioned issues with NPM and pre-commit might block us here. What issues are you describing?

This repo is currently using Prettier (Node.js package) through a hook, so I don't think we'll have trouble directly with Node.js. I know we've done similar custom hooks for npm run build that rely on NPM:

Is this the piece you had trouble with on the website?

For this issue, I just put up and merged

This does not supersede this issue, it was just to get something working while this issue is still open. The circleci configuration can be reduced back later though.