search

readthedocs / ext-theme

Read the Docs drop in replacement site templates
2 stars 2 forks source link

Support: define SemanticUI `field_file.html` #297

Closed humitos closed 8 months ago

humitos commented 8 months ago

It seems that crispy forms semanticui uses a file that doesn't define. I'm following the pattern we have here to "override" this file in our own repository.

This is required for https://github.com/readthedocs/readthedocs.org/pull/11193 Related https://github.com/readthedocs/ext-theme/issues/296

humitos commented 8 months ago

Yeah, I'm not sure either. I copied it from one of the others you put in this repository as well and deleted the non-related-to-this-field-type things 😄 . It works fine on https://github.com/readthedocs/readthedocs.org/pull/11193 at least --but I suppose there may be some edge cases that don't work.

agjohnson commented 8 months ago

Sounds like it is probably good then, but if we hit issues that would be the next step.