Port CAS related changes

[stsewd]

Normal login

Login restricted to one provider

Login when trying to access a documentation page

Closes https://github.com/readthedocs/ext-theme/issues/276

[agjohnson]

This looks great! I'll jump into the code next, but a couple things just looking at the screenshots:

• Showing the email login tab as disabled rather than hide it completely gives the user a bit more information and makes the "Connected account" tab button make more sense too. You should be able to add the disabled class to the tab. Future improvements here would be giving the user feedback on why email is disabled.
• The block on "Do you have a password" feels a bit misplaced. It probably makes more sense as another tab at the top of the section ("Log in with password") rather than prose copy on all tabs. This does start to crowd the tab bar, but we can adjust this afterwards. This tab might be better to hide on the dashboard login, as opposed to using the disabled class.

I have a few fixes we can lump together to address layout issues: making room for a third tab, fixing floating issues on the button and checkbox, and maybe making the tabs a bit more obvious.

[humitos]

Showing the email login tab as disabled rather than hide it completely gives the user a bit more information

👍🏼

[humitos]

This is looking good 💯 . I haven't check the code, but I have some feedback from the screenshots:

• When accessing a documentation, can we check if the organization has SSO enabled and only show that provider? That way, there will be one and only one way to login.
• When accessing the documentation, can we show the "Do you have a password?" option only if the organization has at least one non-expired password?
• Can we make the "Forgot your password?" text less prominent? Maybe small and under the "Login" button?

[stsewd]

When accessing a documentation, can we check if the organization has SSO enabled and only show that provider? That way, there will be one and only one way to login.

I think that's already done

https://github.com/readthedocs/readthedocs-corporate/blob/7dc57dea6cbf9b9a258ff9165650e613b4522c1d/readthedocsinc/proxito/views.py#L57-L64

When accessing the documentation, can we show the "Do you have a password?" option only if the organization has at least one non-expired password?

That feels leaky from our part

[stsewd]

@agjohnson no idea how to fix the width

Also, I put a title as a help text when the email tab is disabled, but it doesn't show as the tab is disabled :/ if we are going to disable that tab, I think we should put some context as why.

[agjohnson]

no idea how to fix the width

The menu bar is a .ui.two.item.menu. If you conditionally change that to .ui.three.item.menu it should keep the width correct. I can help adjust the form visually afterwards, as this will compact all the buttons.

if we are going to disable that tab, I think we should put some context as why.

Ideally we would, yeah. Let's put this on the follow up list, I can help polish these things afterwards. I feel at least with the option disabled that's some amount of visual information. Maybe we end up disabling the tab form instead though.

Can we make the "Forgot your password?" text less prominent?

Let's put this on the follow up list with other visual tweaks too.

[stsewd]

[agjohnson]

Looking great, I'll take a look at the code and have opened up an issue to address all of the visual fiddling next:

• 312