search

readthedocs / ext-theme

Read the Docs drop in replacement site templates
2 stars 2 forks source link

CI: Run pre-commit #319

Closed stsewd closed 6 months ago

stsewd commented 6 months ago

I did a local run with pre-commit run --all-files (the changes on the .rst file come from that), but on CI I'm just checking the last diff as the pre-commit doc recommend.

pre-commit makes use of node internally, so node is needed in that step, also merging the node and python lint jobs into one.

Closes https://github.com/readthedocs/ext-theme/issues/268

agjohnson commented 6 months ago

This looks good to merge to me. I had split up the linting in #311 but that was a temporary hack, so combining the jobs again is fine.

Thanks for jumping in here @stsewd!