readthedocs / ext-theme

Read the Docs drop in replacement site templates
2 stars 2 forks source link

Fix a number of display issues with login view #331

Closed agjohnson closed 5 months ago

agjohnson commented 5 months ago

image

image

image

image

humitos commented 5 months ago

In the first image, I think it should say "Email" instead of "Login" that form field, since the option selected is "Email" under "Log in using".

Also, in the first image, there is a | at the end of the error message. Not sure where that comes from.

agjohnson commented 5 months ago

Also, in the first image, there is a | at the end of the error message. Not sure where that comes from.

Hah, this is my Firefox/Wayland/maybe an extension? I can't get rid of the damn things, they're everywhere!

In the first image, I think it should say "Email" instead of "Login"

Agreed, but this comes from the underlying form instance, from Django/Allauth. In templates, all we're doing is:

https://github.com/readthedocs/ext-theme/blob/f730326fcc888f46bc51b3211e6f5ae58e06517f/readthedocsext/theme/templates/account/login.html#L71-L89