readthedocs / ext-theme

Read the Docs drop in replacement site templates
2 stars 2 forks source link

Teams: invites on team cause exception in AdminPermission #354

Closed humitos closed 4 months ago

humitos commented 4 months ago

Hitting https://beta.readthedocs.com/organizations/read-the-docs-qa/teams/qa/ returns 500 to me.

Sentry issue: https://read-the-docs.sentry.io/issues/5389496991/?project=161479&query=is%3Aunresolved+%21message%3A%22%21message%3A%22%21message%3A%22SystemExit%22+%21message%3A%22frame-ancestors%22&referrer=issue-stream&statsPeriod=14d&stream_index=0

agjohnson commented 4 months ago

It seems the issue here is not editing the team, but just viewing and only this particular team. Specifically, this is on the view listing the members of the QA team.

https://beta.readthedocs.com/organizations/read-the-docs-qa/teams/qa-user-auth/ does not show this error.

Looks like this comes from https://github.com/readthedocs/ext-theme/blob/75ccbc474263003ac5cd0e5dcf710a8a85d1d3e0/readthedocsext/theme/templates/invitations/partials/invitation_list.html#L29 ultimately, so I'm guessing this bug is strictly when users have been invited to a team.

agjohnson commented 4 months ago

I can fix this in templates, but I would consider this a bug in community instead. Team should be supported by AdminPermissionBase.admins().

agjohnson commented 4 months ago

Fixed at: