search

readthedocs / ext-theme

Read the Docs drop in replacement site templates
2 stars 2 forks source link

Fix mobile viewport size on build detail view #356

Closed agjohnson closed 4 months ago

agjohnson commented 4 months ago

The text menu was not stacking so the viewport width was matching the menu width. This also removes some unnecessary padding on the wrapping segment.

image

Fixes #308

agjohnson commented 4 months ago

There are separate, unrelated issues with wrapping that I'll be addressing with something like #334 and some other updates to that.

But it seems you also aren't testing with a proper mobile viewport too. Mobile viewports/DPR can be tested with Firefox responsive design mode. When using a viewport that respects width=device-width viewport size, I haven't noticed that overflow issue.

image

The command UI is much more broken on mobile -- command expansion is broken completely there.

humitos commented 4 months ago

I'm using that same Firefox feature using the default device I think. I don't remember touching it 🤷‍♂️

Anyways, this PR seems okay to be merged. We can address the other issue in other PRs

agjohnson commented 4 months ago

The default device is just a custom window size with DPR: 1. You can use one of the predefined devices to view something closer to what mobile users will see.