search

readthedocs / ext-theme

Read the Docs drop in replacement site templates
2 stars 2 forks source link

Notifications: cancelled notifications are shown for organizations #359

Closed humitos closed 3 months ago

humitos commented 4 months ago

It seems we are listing all the notifications for organization, even those that are already cancelled:

https://github.com/readthedocs/ext-theme/blob/d758c66ed0d4cce607e7405a3e2cb8e216f15ff8/readthedocsext/theme/templates/organizations/partials/header.html#L16-L22

Also, it seems that we are using a different approach for organizations than for projects:

https://github.com/readthedocs/ext-theme/blob/d758c66ed0d4cce607e7405a3e2cb8e216f15ff8/readthedocsext/theme/templates/projects/base.html#L8-L14

Should we port the notifications for organization to the readthedocs-notification-list pattern?

agjohnson commented 4 months ago

Yeah this should use the same API pattern, not sure why it doesn't already