readthedocs / ext-theme

Read the Docs drop in replacement site templates
2 stars 2 forks source link

Projects: disable elipsis when user doesn't have permissions #363

Closed humitos closed 3 months ago

humitos commented 3 months ago

Show the elipsis as disabled when the user doesn't have permissions. Follows the same pattern with the documentation/book icon that is disabled when there is no successful build yet.

Previously

Screenshot_2024-06-05_16-06-53

New behavior

Screenshot_2024-06-05_16-17-29

humitos commented 3 months ago

Yeah, I'm sure we will find extra common actions over time and we will need to change this logic to keep making the button available but without the "admin" submenu. However, I don't have any good action to include there in mind yet.

agjohnson commented 3 months ago

Same, I thought I might find more. We could reverse this and just make it the admin icon only, instead of ellipsis. I'm fine with this as is though, we can probably find something else for the menu