Gold view templates uses inline JS

readthedocs / ext-theme

Read the Docs drop in replacement site templates

2 stars 2 forks source link

Gold view templates uses inline JS #407

Open stsewd opened 2 months ago

stsewd commented 2 months ago

We should probably just handle everything from Stripe instead of embedding stripe into our site.

https://github.com/readthedocs/ext-theme/blob/846d19484eb2972f80365cb48d3ac53b935815b0/readthedocsext/theme/templates/gold/subscription_form.html#L22-L35

I'll probably add a specific rule for this view to our CSP header.

agjohnson commented 2 months ago

I either punted on this UI completely, and this is broken currently, or this is just an orphaned template/block that isn't used. Very agreed we shouldn't be doing this either way though.