Open ericholscher opened 1 month ago
The reason I have been -1 on this approach is because it creates two view docs buttons on the build detail page. The top most button will go to the wrong docs too (latest) instead of the PR build/branch docs for the build.
I still think this should be a singular button
This button will eventually move to the project wide header, here:
A temporary solution until someone wants to make this into a dropdown would be to move the current view docs button in the build detail page up to a {% block project_header_navigation_docs %}
and override this blck on the build detail page. However, due to how this is included, this is not straight forward. This way at least a singe button doesn't make for bad UX on the build detail page and it points to a reasonable version on all of the project pages.
I still feel a dropdown is the best UX here and is my overall goal still.
For now, I've just hidden the View docs button on build pages, which seems like a reasonable approach?
We talked through this one in person, I mentioned:
The answer here does need to be more complex. A web component fits here short and long term, I'm poking something more flexible now.
I think this is still worth getting in, especially now that we are pointing folks to this. I think my current PR solves this problem in a simple way for now, and we can do the v2 later when we have more time to dive into it?
Ping @agjohnson -- :+1: on shipping this simple version for now, and we can work to make it the better smart version in the future?
This gives a basic way to get to the docs like the old dashboard. I was doing a bunch of local dev on the new dashboard and kept getting annoyed at not being able to get to the docs in an obvious way.
I think this is important and is a middle ground until we can work on a fancier verison.