search

readthedocs / readthedocs-build

Work in Progress builder
19 stars 25 forks source link

build virtualenv with configured python version #15

Closed tharvik closed 7 years ago

tharvik commented 8 years ago

actually use the version field of the configuration to build the virtualenv.

also, small refactoring to give directly the python_config to VirtualEnv

ericholscher commented 7 years ago

Sorry this has been sitting for so long... What is the value of building virtualenv with the actual version? We pass in the argument that tells it what binary to choose, so it shouldn't matter what actual Python gets called, right?

tharvik commented 7 years ago

From what I recall, it was to allow building some python3 specific code. Forcing the use of python2 disallowes to building with some new syntax of python3 (function annotations, ...).

ericholscher commented 7 years ago

The virtualenv should be using python 3 though, so any building of the docs should work fine. It's just the initial virtualenv creation, which shouldn't be running any user-supplied code.

ericholscher commented 7 years ago

I see this is for local building, so I think it makes sense. Will merge it! :+1: