search

readthedocs / readthedocs-build

Work in Progress builder
19 stars 25 forks source link

Check for readthedocs file with yaml extension #48

Closed StefanoChiodino closed 6 years ago

StefanoChiodino commented 6 years ago

Fixes https://github.com/rtfd/readthedocs.org/issues/4102. Ref. https://github.com/rtfd/readthedocs.org/pull/4129 that documents this change.

StefanoChiodino commented 6 years ago

There's a test that is failing on travis but not on my pc. I think I'll have to change that list to a set anyway. I'll check it later.

StefanoChiodino commented 6 years ago

Weirdly enough 18 tests fails for me on master, that's weird.

stsewd commented 6 years ago

I think I'll have to change that list to a set anyway

Yeah, that should be a set.

StefanoChiodino commented 6 years ago

@stsewd Is this good, or should I change the description to read something like readthedocs.yml (with optional '.' prefix or 'yaml' file extension) ??

StefanoChiodino commented 6 years ago

Any luck with this?

stsewd commented 6 years ago

@StefanoChiodino I'll try to review this in the morning

StefanoChiodino commented 6 years ago

@stsewd happy with this?

agjohnson commented 6 years ago

Okay, this is now unblocked. As noted, we are moving this logic to rtfd/readthedocs.org repository. The next step is going to be replicating these changes in that repo. Sorry this is probably an annoying request, I don't know the best way to port this over easily. A diff might get most of the way there if you are able to put the change in soon. Once the code there deviates, this PR is going to need a manual rewrite, likely.

StefanoChiodino commented 6 years ago

Done, hopefully (tests aren't playing nice on my machine) https://github.com/rtfd/readthedocs.org/pull/4512

stsewd commented 6 years ago

Ported on https://github.com/rtfd/readthedocs.org/pull/4512