Closed humitos closed 3 years ago
@agjohnson @ericholscher we may want to include the upgrade for Rust to 1.53 (https://www.rust-lang.org/es) in this PR as well since it was already requested by a user in #170 --what do you think?
This looks mostly safe. I think we should move forward with it after feedback in #173.
@agjohnson @ericholscher we may want to include the upgrade for Rust to 1.53 (https://www.rust-lang.org/es) in this PR as well since it was already requested by a user in #170 --what do you think?
I'd like to handle these upgrades one at a time if possible. I think doing conda & python 3.10 is probably safe, since nobody is using 3.10 yet. So the primary breaking change here is conda, which will almost certainly break something, but not too many conda users using testing
.
Once tests pass, I will merge this PR and tag it as 7.0.8
so it builds on Docker Hub as well. After that, we will do some QA with @astrojuanlu on some projects using Conda and Python3.10
Once tests pass
Sorry, where are you seeing the tests? There are no checks in this PR
Sorry, where are you seeing the tests? There are no checks in this PR
Yeah, I'm dealing with it. They were running in TravisCI. I'm migrating them to CircleCI and having multiple colorful issues 🙃 --but I'm close.
Image 7.0.8 is building in docker hub at https://hub.docker.com/repository/registry-1.docker.io/readthedocs/build/builds/90e9c07e-1986-4a18-abb5-0218b1def3cb
Install Python 3.10.0b3 and upgrade to Miniconda3-py38-4.9.2.
Upgrading Miniconda2 to Miniconda3 changes the default behavior when the user doesn't specify the python version (
build.python.version
). The environment will be created with Python3 by default now instead of Python2. See https://github.com/readthedocs/readthedocs-docker-images/issues/86I don't think this will affect too many users since this PR is going to be merged into
release/7.x
branch (testing
image) that only a few users are currently using.Closes #152 Closes #173 Closes #171 Related #147 Related #158 Requires https://github.com/readthedocs/readthedocs.org/pull/8328 Requires a git tag
7.0.8
on this repository once this PR is merged intoreleases/7.x
Requires a PR in -ops upgrading the hash fortesting
image once it's built on DockerHub