search

readthedocs / readthedocs-docker-images

Docker image definitions used by Read the Docs
115 stars 70 forks source link

asdf: update `asdf` and all its plugins #189

Closed humitos closed 1 year ago

humitos commented 1 year ago

This will allow us to be smarter about when to reshim.

With this update, it will be handled automatically by asdf and we won't require a custom chunk of code in our application:

https://github.com/readthedocs/readthedocs.org/blob/a5965129c61b9bcdff2f2098ff7ce7f8c093dc74/readthedocs/doc_builder/director.py#L373-L386

Currently, multi-lines commands that install something with pip and immediate after that, inside the multi-line command try to use the executable installed, fail because it's not automatically reshimed.

By reshiming at asdf level, this case will be solved.

Related: https://github.com/readthedocs/readthedocs.org/pull/9150#discussion_r882849790 Related: https://github.com/asdf-community/asdf-python/pull/136 Related: https://github.com/readthedocs/readthedocs.org/issues/10103

humitos commented 1 year ago

Once this PR gets merged, we need to re-build the Docker images and update them to Docker Hub. Besides, we should re-build the tools as well to avoid any potential incompatibilities with new -dev libraries in the newer Ubuntu images.

humitos commented 1 year ago

This upgrade may solve https://github.com/readthedocs/readthedocs.org/issues/10108 as well, since we will be using a newer Ubuntu 22.04 patch version.

humitos commented 1 year ago

I created a Deploy Key from CircleCI so the tests start working again.

We need to update the AWS_ credentials on CircleCI to be able to push the resulting .tar.gz to our buckets.

humitos commented 1 year ago

I tested it locally after re-building the Docker image and it works great:

Screenshot_2023-03-09_12-29-00

We don't require the asdf reshim python written by the user anymore 🎉