Closed agjohnson closed 1 year ago
Developments: @humitos noted that we in fact do not have openssl 1.1 headers installed, and we found installing them (package libssl-dev
) breaks a lot of things.
We are considering unpacking the package to a separate path, building against that using CFLAGS
/LDFLAGS
.
Also also, we will have a worse version of this in september, when the urllib3 package drops support for openssl 1.1.1 (ubuntu 20.04)
Developments: @humitos noted that we in fact do not have openssl 1.1 headers installed, and we found installing them (package
libssl-dev
) breaks a lot of things.
apt update
apt install libssl-dev # it removes some packages due to conflicts
<compile Python 3.7.x and 3.8.x with the installed libssl-dev>
apt install libssl1.0-dev node-gyp nodejs-dev npm # re-install the packages that were removed in the previous step
I was able to compile Python with a newer SSL version this way and able to import requests
and make a request. I think this could be a good temporal fix for now.
We are considering unpacking the package to a separate path, building against that using
CFLAGS
/LDFLAGS
.
I tried passing different flags and I was not able to build with the openssl that I downloaded manually. We may need to keep researching about this if we want to go this way.
Also also, we will have a worse version of this in september, when the urllib3 package drops support for openssl 1.1.1 (ubuntu 20.04)
I tested this locally and it worked. The tutorial-template
and linkcheck
branch from test-builds
built successfully with the image that this Dockerfile generates.
I want to be clear on this. I'm not happy with the solution and I strongly think we need to work on deprecating these images and remove the ability for users to use them. They are gonna cause us this type of issues all the time. However, I'm fine moving forward with this as a quick/hotfix for now, but we should keep the conversation active and do the required work to remove this images from our servers 😄
I'm planning to finish the build, upload to Docker Hub, update Salt in -ops and do a hotfix release today if we have enough time. Otherwise, it's gonna be a tomorrow thing.
A couple things happening here, but to summarize:
To test / repro (after rebuilding this image):