readthedocs / readthedocs-sphinx-search

Deprecated: Enable search-as-you-type feature for docs hosted by RTD.
https://readthedocs-sphinx-search.readthedocs.io/
MIT License
33 stars 16 forks source link

Prevent triggering `hideSearchWords` when closing the modal #104

Open stsewd opened 2 years ago

stsewd commented 2 years ago

Two things:

Closes https://github.com/readthedocs/readthedocs-sphinx-search/pull/103

stsewd commented 2 years ago

Docs should pass after https://github.com/readthedocs/readthedocs-sphinx-search/pull/105 is merged, and you should be able to test this at https://readthedocs-sphinx-search--104.org.readthedocs.build/en/104/index.html?highlight=sphinx&rtd_search=press%20escape

mgeier commented 2 years ago

Could someone please rebase to check if it works now?

stsewd commented 2 years ago

This can be tested at https://readthedocs-sphinx-search--104.org.readthedocs.build/en/104/index.html?highlight=sphinx&rtd_search=press%20escape, but there is this small problem https://github.com/readthedocs/readthedocs-sphinx-search/pull/104#discussion_r821045935