readthedocs / readthedocs.org

The source code that powers readthedocs.org
https://readthedocs.org/
MIT License
8.04k stars 3.58k forks source link

hidden ads is not propagated to translations #10170

Open 12rambau opened 1 year ago

12rambau commented 1 year ago

Details

Expected Result

I started the gold membership with 2 of my accounts (sepalbot and 12rambau) to hide the ads for some of my projects and support readthedocs. When dealing with the sepal-doc project, my issue is that the translations are stored in a separated project so the ads are only hidden in the english version and still shows on the french and spannish one.

Is it normal (my guess is yes) ? Is it something you would change (propagate the gold membership to project translation) ?

humitos commented 1 year ago

We aren't removing that capability, but the cross site cookies needed to make that work do not work on Safari or Firefox. We'll leave the functionality in for Chrome users, but we aren't going to sell it since it doesn't work widely.

(from #10459)

I'm closing this issue because we won't be investing time "to fix" this problem since eventually we will remove the feature completely due to technical limitations.

12rambau commented 1 year ago

You mean support for multi languages version ?

humitos commented 1 year ago

Oh, I'm sorry. I miss read the issue. You are removing ads from your project in particular. OK, OK. I'm re-opening it since I'm not sure about the decision we will take about that now.

12rambau commented 3 weeks ago

Any decision on this one ?

ericholscher commented 1 week ago

We discussed this and it makes sense to apply this to subprojects. Now we just need to write the code :)

humitos commented 1 week ago

We discussed this and it makes sense to apply this to subprojects

You made a typo here. We want to apply this (removing ads) to translations and not subprojects 😄