search

readthedocs / recommonmark

A markdown parser for docutils
https://recommonmark.readthedocs.io/
MIT License
340 stars 252 forks source link

Set rawsource value of each node to use as translation source for Sphinx i18n feature #187

Closed jpmckinney closed 3 years ago

jpmckinney commented 5 years ago

This fixes a regression. @shimizukawa originally fixed this in https://github.com/readthedocs/recommonmark/commit/fc18fa7431752d2a69fe19e634ca981d6205a83d

This depends on the following bug being fixed in commonmark: https://github.com/readthedocs/commonmark.py/pull/225

Note that Markdown can't be translated properly without these two bug fixes.

noritada commented 4 years ago

As I wrote in #208 , this PR will close #163 and also close #169. I am also troubled by the i18n issue and this PR (plus related fix of commonmark) works well for me. I hope this PR will be merged.

jpmckinney commented 3 years ago

I use https://myst-parser.readthedocs.io/en/latest/ and https://markdown-it-py.readthedocs.io/en/latest/ instead now.

astrojuanlu commented 3 years ago

I use https://myst-parser.readthedocs.io/en/latest/ and https://markdown-it-py.readthedocs.io/en/latest/ instead now.

These are more maintained these days, and that's one of the reasons why we proposed to sunset recommonmark https://github.com/readthedocs/recommonmark/issues/221 please head over to that conversation, because unfortunately it's unlikely that this issue is solved.

jpmckinney commented 3 years ago

I am abandoning the PR given #221.