search

readthedocs / sphinx-notfound-page

Create a custom 404 page with absolute URLs hardcoded
https://sphinx-notfound-page.readthedocs.io/
MIT License
48 stars 32 forks source link

Support CSS/JS files added by extensions in older Sphinx versions #156

Closed humitos closed 3 years ago

humitos commented 3 years ago

Older Sphinx versions does not have setup_css_tag_helper as 4.x does: https://github.com/readthedocs/sphinx-notfound-page/pull/153/files#diff-83bfdb6415a043b1888e7ce5240bd78ea1f236af2f7094fcb5e7702f8672aa32R301

I'm using the old method for Sphinx<4.x which is pretty similar to how toctree and pathto work.

Closes #120

domdfcoding commented 3 years ago

Sorry, didn't get a chance to look at this before you merged, but working fine for me 👍. Thanks

humitos commented 3 years ago

Great! I made a new release today. Feel free to open an issue if you find a problem.