readthedocs / sphinx-notfound-page

Create a custom 404 page with absolute URLs hardcoded
https://sphinx-notfound-page.readthedocs.io/
MIT License
50 stars 32 forks source link

HTML logo/favicon support #182

Closed humitos closed 2 years ago

humitos commented 2 years ago

After the changes done in https://github.com/sphinx-doc/sphinx/pull/8737 the favicon and logo stop working properly on 404 pages.

We need to call our finalize_media function that overrides the pathto funcion in the context before Sphinx resolves the logo_url and favicon_url so it uses our overwritten pathto function.

Closes #180