Don't test for jquery presence with Sphinx 6+

readthedocs / sphinx-notfound-page

Create a custom 404 page with absolute URLs hardcoded

https://sphinx-notfound-page.readthedocs.io/

MIT License

48 stars 32 forks source link

Don't test for jquery presence with Sphinx 6+ #218

Closed befeleme closed 12 months ago

befeleme commented 1 year ago

This is a hotfix for an issue we faced when building sphinx-notfound-page with Sphinx 6.1.3 in Fedora. The jquery files are no longer part of the main Sphinx contents, they were moved to the sphinxcontrib.jquery extension. I couldn't tell whether the presence of the files is truly needed for sphinx-notfound-page to function properly or if they're checked for just to make sure whatever Sphinx injects, was correctly added to the page. I'll appreciate feedback here :)

humitos commented 12 months ago

This patch makes sense to me. Can you update the PR to make CircleCI to succeed?

befeleme commented 12 months ago

I started to look at it but realized this has been resolved by https://github.com/readthedocs/sphinx-notfound-page/pull/220/ Thank you!