Closed hynek closed 12 months ago
The helper was removed in Sphinx 7.2.0 at https://github.com/sphinx-doc/sphinx/commit/4b082f7db. We will need to use the new API for CSS and JS here. See https://github.com/sphinx-doc/sphinx/issues/11608
I released https://pypi.org/project/sphinx-notfound-page/1.0.0rc1/, please give it a try and let me know if it works fine for your use case.
Works locally with https://github.com/python/devguide/pull/1155 with requirements.txt
:
-sphinx-notfound-page
+sphinx-notfound-page==1.0.0rc1
Thanks!
Works fine here as well - thanks for the quick fix!
I plan to wait a couple of days before releasing the final 1.0.0 -- I think I will do it next Wednesday.
Not sure if it is related, but I got an error::
Theme error:
An error happened in rendering the page 404.
Reason: ValueError("invalid literal for int() with base 10: ''")
.. I'm still in analysis
FWI: in the theme.conf I had to set globaltoc_maxdepth
to an integer ..
[options]
globaltoc_maxdepth = 5
it seems the default is an empty string ...
File "site-packages/sphinx/themes/basic/../basic/layout.html", line 60, in template
{%- include sidebartemplate %}
File "site-packages/sphinx/themes/basic/globaltoc.html", line 11, in top-level template code
{{ toctree(includehidden=theme_globaltoc_includehidden, collapse=theme_globaltoc_collapse, maxdepth=theme_globaltoc_maxdepth) }}
File "site-packages/jinja2/sandbox.py", line 393, in call
return __context.call(__obj, *args, **kwargs)
File "site-packages/notfound/extension.py", line 128, in toctree
toc = global_toctree_for_doc(
File "sphinx/environment/adapters/toctree.py", line 86, in global_toctree_for_doc
maxdepth=int(maxdepth),
ValueError: invalid literal for int() with base 10: ''
There was a similar issue in the past:
I assume the issue has been back by:
@return42 I opened #221 to track the issue you are reporting more in deep.
Can confirm โ thanks for fixing!
Works :+1: .. thanks a lot for fixing! Not sure, may you also want to close ...?
Related:
Not sure, may you also want to close ...?
I think we can close it because I understand it's an upstream issue, yeah ๐๐ผ
Full traceback referenced in log: