Closed humitos closed 12 months ago
@humitos Please consider cherry-picking the two commits on this branch: https://github.com/AA-Turner/sphinx-notfound-page/tree/humitos/drop-support-old-versions to this PR
sphinx-prompt
due to version incompatability (Sphinx 4+ blocks selection of the prompt by default regardless)language = None
)pathto
and toctree
A
When all tests pass, I will do a 1.0.0rc
with all these changes 🎉
This looks good. We should update the setup.py with this change as well, I think?
Good point. We are using pyproject.toml
in this repository and AA-Turner already updated 👍🏼
I released https://pypi.org/project/sphinx-notfound-page/1.0.0rc1/, please give it a try and let me know if it works fine for your use case.
Thanks @humitos! All seems well
A
Just tried v1.0.0rc1
for our repository too, and all is looking good! Thank you for getting this done so quickly!
I'm matching the plan with
sphinx_rtd_theme
to reduce maintainers work: https://github.com/readthedocs/sphinx_rtd_theme/pull/1500Closes #217 Closes #219 Closes #216