readthedocs / sphinx-notfound-page

Create a custom 404 page with absolute URLs hardcoded
https://sphinx-notfound-page.readthedocs.io/
MIT License
48 stars 32 forks source link

Drop support for Sphinx<5 #220

Closed humitos closed 12 months ago

humitos commented 12 months ago

I'm matching the plan with sphinx_rtd_theme to reduce maintainers work: https://github.com/readthedocs/sphinx_rtd_theme/pull/1500

Closes #217 Closes #219 Closes #216

AA-Turner commented 12 months ago

@humitos Please consider cherry-picking the two commits on this branch: https://github.com/AA-Turner/sphinx-notfound-page/tree/humitos/drop-support-old-versions to this PR

A

humitos commented 12 months ago

When all tests pass, I will do a 1.0.0rc with all these changes 🎉

humitos commented 12 months ago

This looks good. We should update the setup.py with this change as well, I think?

Good point. We are using pyproject.toml in this repository and AA-Turner already updated 👍🏼

humitos commented 12 months ago

I released https://pypi.org/project/sphinx-notfound-page/1.0.0rc1/, please give it a try and let me know if it works fine for your use case.

AA-Turner commented 12 months ago

Thanks @humitos! All seems well

A

namurphy commented 11 months ago

Just tried v1.0.0rc1 for our repository too, and all is looking good! Thank you for getting this done so quickly!

humitos commented 11 months ago

I released v1.0.0. I hope it works for everybody 🙏🏼