search

readthedocs / sphinx_rtd_theme

Sphinx theme from Read the Docs
https://sphinx-rtd-theme.readthedocs.io/
MIT License
4.78k stars 1.74k forks source link

Some translation issues #1327

Open Geeyun-JY3 opened 2 years ago

Geeyun-JY3 commented 2 years ago

Hi I am a translator of zh_CN. Here are some issues about the translation.

  1. Merge these three strings into one. https://github.com/readthedocs/sphinx_rtd_theme/blob/b553aa6626d4910b581acb179f93defcb6a5a1c8/sphinx_rtd_theme/footer.html#L50-L57 image This sentence is currently separated into 3 strings in Transifex. It is inconvenient for some languages while translating because the sequence of words is not completely the same as English in some languages. I hope it could correspond to one string in Transifex.

  2. Obsolete entries(strings) are still parsed in Transifex. Not sure if this issue is related to Transifex itself. image

BTW, I want to improve the zh_CN translation. But some strings I want to change are marked as reviewed in Transifex. Who can I find to help me cancel that reviewed state in Transifex?

agjohnson commented 2 years ago

Thanks for the report, this is very helpful!

The three strings should indeed be a singular string. Actually, I'm not sure why we never changed this, it's not a pattern we'd normally use for our localization elsewhere. :shrug:

Obsolete entries(strings) are still parsed in Transifex. Not sure if this issue is related to Transifex itself.

I believe it is just Transifex doing something not quite expected here. I have noticed this before and it wasn't clear how to remove these strings. I believe if I had any success here with one of our projects, the deleted strings came right back after the next sync to Transifex.

Who can I find to help me cancel that reviewed state in Transifex?

We used to have more coordinators on the zh_CN locale I believe, but looks like I'm the only one. I wasn't aware that the reviewed state blocks further attempts to translate.

It does look like there were a number of edits that needed approval, I reviewed all of these. Let me know if there are others that need to be edited.

I'll leave this open to come back to merging the three strings, probably with a future release like 1.2

Geeyun-JY3 commented 2 years ago

Emmm I would suggest keeping all of strings as unreviewed so translators do not need to look for coordinators or reviewers to cancel the reviewed state. Translators may do the translation work and keep improving them for a long time.

TBH, I want to edit about 10 translation of zh_CN.

agjohnson commented 2 years ago

We use reviewed/unreviewed state to determine if the translation is ready to use, so we'd want to retain that still. I'll go ahead and just give you reviewer status so you have the ability to change reviewed strings at least though.

Geeyun-JY3 commented 2 years ago

Thank you!

benjaoming commented 1 year ago

@Geeyun-JY3 how did translating remaining strings go? We are going to release 1.2 and I just noticed this issue.

Geeyun-JY3 commented 1 year ago

how did translating remaining strings go?

All strings have been translated before I filed this issue except the Obsolete entries(strings) I mentioned above. And it seems nothing different in Transifex.

benjaoming commented 1 year ago

That sounds good! Translations have been pulled from Transifex at each release (also pre-releases), so if everything looks good in Transifex, it's also up to date here on GitHub.

Thanks for translating! I'm going to close the issue here as fixed :)

benjaoming commented 1 year ago

Btw regarding the obsolete strings, I don't really know why they would still be there in Transifex. As @agjohnson mentioned, it might be a bug in Transifex. If it becomes a larger issue, we should address it, but for now it seems to be just about a very few couple of simpler words.

Geeyun-JY3 commented 1 year ago

@benjaoming But that three strings I mention in 1 are still not merged into one string. That is to say these three strings still does not look good in Transifex.

benjaoming commented 1 year ago

@Geeyun-JY3 oh I see, I was reading the conversation and thought it was solved.

These translation sources are actually changed in https://github.com/readthedocs/sphinx_rtd_theme/pull/1410 -- I will propose that this PR also merges the 3 strings into one string.

benjaoming commented 1 year ago

A fix is now proposed in #1410 :+1: