Remove Sphinx<5 compatibility leftovers

readthedocs / sphinx_rtd_theme

Sphinx theme from Read the Docs

https://sphinx-rtd-theme.readthedocs.io/

MIT License

4.81k stars 1.74k forks source link

Remove Sphinx<5 compatibility leftovers #1512

Closed humitos closed 11 months ago

humitos commented 1 year ago

Remove blocks with logic for Sphinx<5
Always use writer-html5 CSS class
Use css_tag for better compatibility with newer Sphinx versions
Closes #1075
Closes #1100
Closes #1101
Closes #1503
Closes #1507

@agjohnson this PR is a good candidate to be included in 2.0rc2 👍🏼 . If you approve it, I can try to make a release myself.

humitos commented 1 year ago

I tested this visually as well with Sphinx 5, 6 and 7 and I didn't find any issue so far.

humitos commented 1 year ago

@agjohnson I split the required changes to support Sphinx >= 7.2 into #1519 and merge that one. I also update this PR with the latest changes.

Now, this PR is only and cleanup of the support for older (now) un-supported versions.

agjohnson commented 1 year ago

With 2.0 released, I think we're ready to merge this and prepare a 2.1a release. We haven't had any more feedback on the CSS changes in the 2.0rc{1,2,3,4} releases, so I think we're safe to continue on.

@humitos thoughts here?

humitos commented 1 year ago

Sounds good to me! I've updated the PR to resolve the conflicts.

humitos commented 11 months ago

This PR is ready to re-review and merge. I kept the injection of css_files code as it's on master which is working properly. On the other hand, I added a small comment for extra_css_files so we don't get confused again with that.