Flyout menu has a scrollbar

agjohnson commented 5 years ago

This is production docs, version latest, Chromium on Linux. Most current passing build is: https://readthedocs.org/projects/sphinx-rtd-theme/builds/8677624/

This could use replication locally. It doesn't quite make sense why this is only on our theme docs and not on any docs using the latest release.

I also just noticed this is happening for me on our RTD docs (https://docs.readthedocs.io)

davidfischer commented 5 years ago

This was introduced in #707. However, I believe we were controlling the scrollbar appearance and maybe that isn't possible anymore.

I see it as well on Mac/Chrome as well as Mac/Firefox.

agjohnson commented 5 years ago

Roger. I see the use case, but I'm -1 on an unconditional scrollbar -- the scrollbar here is visually distracting and looks accidental. Cross browser support for styling/hiding scrollbars is notoriously awful, so i'd like to avoid going much further there.

Options for resolution:

Don't use a vertical listing of versions here -- I've wanted this, but it's a larger deviation that would be difficult to introduce. :+1: long term, but :-1: short term from me on this
Make version block scrolling if height is exceeded, not the whole menu
Make whole menu scrollbar optional if height is exceeded -- this can potentially introduce issues with spacing as browsers account for the scrollbar width in different ways. I believe this shouldn't be an issue

agjohnson commented 5 years ago

A PR is now up for this at #835. I still need to figure out a pattern to test the badge only css though.

humitos commented 2 months ago

This is still happening today on Chrome, but it doesn't happens on Firefox. Note that our documentation now uses addons: https://docs.readthedocs.io/en/stable/

readthedocs / sphinx_rtd_theme

Flyout menu has a scrollbar #791