search

readthedocs / sphinxcontrib-dotnetdomain

A Sphinx domain for .NET languages
MIT License
15 stars 17 forks source link

Feature/Sphinx 3.2.1 #66

Closed ArtOfSettling closed 4 years ago

ArtOfSettling commented 4 years ago

I'm not sure if you are still accepting pull requests for this project, but I noticed that this extension does not work with Sphinx 3.2.1, as you can see the changes required to get it working are quite small, but likely break backwards compatibility.

If this pull request is not useful, let me know what is required and i'll make changes to get it integrated if possible. If you can't accept this, would you expect users to stick with an older version of sphinx for compatibility?

stsewd commented 4 years ago

Hi, thanks for the contribution. Indeed, we don't maintain this repo actively, but we do accept PRs. For your questions, I think it should be fine to drop support for python 2.7 and old versions of sphinx (<1.8).

/cc @readthedocs/core

humitos commented 4 years ago

Thanks @ArtOfSettling!

I never touched this repository. That said, I'm fine accepting PRs for this repository to keep it compatible with newer versions of Sphinx. :+1: on dropping support for Python 2.7 and Sphinx <1.8

It would be good if these changes fix the tests and add newer versions of Python and Sphinx, so they run over these newer versions. Besides that, we should include these changes in a CHANGELOG.rst and make a release of a major version of this extension that includes these changes.

ArtOfSettling commented 4 years ago

Hey, ok thanks, i'll get on that and make another pull request later.