search

readthedocs / website

The Read the Docs community website
15 stars 5 forks source link

Move hosting to readthedocs.com #192

Open agjohnson opened 1 year ago

agjohnson commented 1 year ago

I don't recall if there was a reason why we set this up on community, but I had to hunt down the configuration here because we didn't share maintainer access to project on community. Our organization/teams make for much less maintenance around user/team access, and keeping our business assets in one place makes sense.

For now I've shared some more access on the community project

There is even already a project on commercial that we were using. I was confused why it didn't have a custom domain and got a little lost figuring out what the configuration was supposed to be.

Tasks:

agjohnson commented 1 year ago

Looks like a busted redirect for readthedocs-hosted.com:

~/ 💀  curl -I https://about.readthedocs.com
HTTP/2 301 
date: Fri, 07 Apr 2023 23:52:09 GMT
content-type: text/html
location: https://about.readthedocs-hosted.com/
x-backend: web-i-0d43aff24b230b1e3
x-served: Nginx-Domain-Redirect
cf-cache-status: MISS
expires: Sat, 08 Apr 2023 00:12:09 GMT
cache-control: public, max-age=1200
server: cloudflare
cf-ray: 7b462ec089d108a9-SEA
alt-svc: h3=":443"; ma=86400, h3-29=":443"; ma=86400
agjohnson commented 1 year ago

Also note, that if you add a about.readthedocs.com custom domain, this breaks the current certificate on the readthedocs.io domain in Cloudflare. Guessing it's smart enough to know that it can't terminate at both? This won't be an issue with the redirect above removed, and it should just cut over successfully.

humitos commented 1 year ago

Fix about.readthedocs-hosted.com redirect https://github.com/readthedocs/readthedocs-corporate-ops/pull/833

Why do we need this? I don't think that nobody is hitting this URL at all. I didn't even know it existed 🙃

I'd say we should remove all the things we are not using instead of maintaining them (e.g. this about project on commercial) and just move forward.

agjohnson commented 1 year ago

Hah yeah that would be my high level feedback here too, but I didn't want to get too deep to resolve this particular issue either.

I also don't really know what purpose this is serving. I'm guessing it is supposed to be the same implementation as the redirect on foo.readthedocs.org -> foo.readthedocs.io, as we used to host on the same domain as the dashboard.

But this was never the case on commercial. I suspect the redirect can be conditionally disabled

ericholscher commented 11 months ago

Yea, this is tech debt from the readthedocs.org transition. We should really cleanup our nginx configs so we don't have this dangling stuff.