search

readthedocs / website

The Read the Docs community website
16 stars 6 forks source link

Fix article image alt attribute #253

Closed agjohnson closed 8 months ago

agjohnson commented 8 months ago

PR #252 dropped the alt text to support HTML in the image credits, but a more accessible fix here is just strip the HTML from the image credits when using the credits in the attribute.

📚 Documentation preview 📚: https://read-the-docs-website--253.com.readthedocs.build/

ericholscher commented 8 months ago

This isn't really explaining the image, it's just a credit. I don't think this is really useful for an alt tag, but 🤷

agjohnson commented 8 months ago

Yeah sure, but it's better than a URL I feel. And we at least can describe the image in the image credits if we want.