search

readthedocs / website

The Read the Docs community website
15 stars 5 forks source link

Remove RSS feed #254

Closed ericholscher closed 5 months ago

ericholscher commented 5 months ago

📚 Documentation preview 📚: https://read-the-docs-website--254.com.readthedocs.build/

agjohnson commented 5 months ago

I mentioned in Front we should fix the site URL, we sort of broke that at some point by making it a relative URL. This affects feed URLs, but also other links in HTML.

The atom feed also has relative URLs:

<title>Read the Docs Newsletter - February 2024</title><link href="blog/2024/02/read-the-docs-newsletter-february-2024/" rel="alternate"></link>

Similar to RSS, relative URLs cause validation errors in Atom as well:

https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fabout.readthedocs.com%2Ffeeds%2Fatom.xml

Ethicalads uses this:

https://github.com/readthedocs/ethicalads.io/blob/main/publishconf.py#L13-L19

We should use something similar in pelicanconf.py, or go back to using publishconf.py.

ericholscher commented 5 months ago

Yea, that looks like a better solution 💯

Pushed an update. I think we should still only support 1 feed type though, so this PR makes sense.