search

readwiseio / logseq-readwise-official-plugin

GNU General Public License v3.0
56 stars 3 forks source link

duplicated resync for deleted & renamed books #17

Open xxchan opened 1 year ago

xxchan commented 1 year ago

Steps to reproduce:

  1. Delete a synced book old name in Logseq
  2. Rename the book to new name in readwise
  3. Initiate Sync in Logseq (with "Resync deleted pages" enabled), now we have the page new name
  4. Initiate again (actually in each sync afterwards), there will be another notification for new name, but nothing changed.

The reason is simple:

Look at the log:

Page 'old name' deleted, going to resync.

Look at settings.json:

"booksIDsMap": {
    "old name": id,
    "new name": id,
}
xxchan commented 1 year ago

Not sure whether https://github.com/readwiseio/logseq-readwise-official-plugin/issues/7 is caused by this issue.

brunojm commented 1 year ago

Thanks @xxchan for reporting this, I'm going to change the way we save the ids info.