search

readwiseio / logseq-readwise-official-plugin

GNU General Public License v3.0
56 stars 3 forks source link

Highlights are added to a graph that is not linked with Readwise #4

Open gijigae opened 2 years ago

gijigae commented 2 years ago

Readwise adds highlights to another graph if I happen to open multiple graphs and one of them is linked to Readwise.

Steps to reproduce

Let's say I have Graph1 and Graph2 and I only configured Readwise for Graph1.

I opened Graph2 first and opened Graph1 afterwards using a link (logseq://graph/Graph1) in Graph2. Readwise added highlights to Graph2 even though it is not configured for Readwise.

brunojm commented 1 year ago

Thanks @gijigae I'm checking this one.

gijigae commented 1 year ago

@brunojm Thanks for the update! I noticed that highlights are added to another graph that is not configured for Readwise even no other instance of graph is present.

edwarddarrah commented 1 year ago

I was able to duplicate it. I removed the plug-in and re-added it. Again the plug-in was added to both my graphs and synced my highlights to both graphs. Thanks for looking into this.

TristanH commented 1 year ago

Thanks @edwarddarrah ... are you saying that new highlights sync to both graphs? Or do you just have the leftover highlights from the previous sync, and new ones on the new graph?

The way it works is that if you remove the plugin, then reconnect it to a new graph, we will load all of your highlights again in the new graph. We don't delete data from the previous graph when you uninstall, as that would be very dangerous. So what you're seeing sounds like it's expected.