readwiseio / obsidian-readwise

Official Readwise plugin for Obsidian
GNU General Public License v3.0
242 stars 23 forks source link

Obsidian plugin #1

Closed tadeoos closed 2 years ago

tadeoos commented 2 years ago

TODO:

@adam-lynch would appreciate if u take a look as well

linear[bot] commented 2 years ago
RW-1733 Obsidian Export

Pull request: [https://github.com/readwiseio/rekindled/pull/731](https://github.com/readwiseio/rekindled/pull/731) Obsidian extension: [https://github.com/readwiseio/obsidian-readwise](https://github.com/readwiseio/obsidian-readwise)

TristanH commented 2 years ago

Plugin is pointing at prod readwise.io when I try to test it :c

looks like I could probably get it working with a .env file? would be sweet to have the README explain how to do that

TristanH commented 2 years ago

Figured out the .env, got to testing and seems to be working quite well! Two things:

  1. It was originally my suggestion for the approach to use the zip file sooooo mostly my fault, but damn generating the zip upfront and then sending it over the wire at once is annoyingly slow before the user gets any real feedback. Maybe we could use the same approach as get_export_status to show the user the syncing progress in the UI while we're generating the zip?

  2. Got this error in console when running the sync:

    CleanShot 2021-07-21 at 00 08 00@2x

(I assume we'll wanna truncate note titles at some limit)

TristanH commented 2 years ago

Otherwise, looking pretty good!