search

readwiseio / obsidian-readwise

Official Readwise plugin for Obsidian
GNU General Public License v3.0
242 stars 23 forks source link

Bug at resync #8

Open cvh-obsi opened 2 years ago

cvh-obsi commented 2 years ago

I installed the plugin, I synced a first time. Then -I highlight a new line in a kindle book -I sync in Readwise (Kindle>Readwise) -back in obsidian, I launch the readwise sync command and the plugin produces an endless sequesnce of "Building export.." popups. Only way to stop this: deactivate, uninstall and restart obsidian Then I reinstalled and reactivated. Then I started a sync .. and again same endless "building exports.." I did this again and I also deleted the "Readwise" folder (and all its content)

https://user-images.githubusercontent.com/81355993/129488797-e5062217-067e-4439-be0b-cb87aef8c68e.mp4

TristanH commented 2 years ago

Hey @cvh-obsi, thanks for the bug report! Can you shoot me the email address associated with your Obisidian account (you can email me at tristan@readwise.io) and I'll take a look for you?

It looks like the sync might just have been taking a long time, but there could also have been a bug on our backend!

cvh-obsi commented 2 years ago

Thanks Hope you ll find the problem as it is a precious link between Readwise and Obsidian My email is the one I sent this email It is definitely not a long waiting time it is more running for nothing, maybe a kind of time out to implement above correcting the bug I could reproduce the bug What has to be corrected is the fact that the loop resume even after restarting Obsidian, even after deactivating and reactivating the plugin and restarting Obsidian. Keep me informed Christian Envoyé de mon iPhone

Le 16 août 2021 à 22:08, TristanH @.***> a écrit :

 Hey @cvh-obsi, thanks for the bug report! Can you shoot me the email address associated with your Obisidian account (you can email me at @.***) and I'll take a look for you?

It looks like the sync might just have been taking a long time, but there could also have been a bug on our backend!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

kometenstaub commented 2 years ago

This happened to me twice today. That's what is logged in the console: picture

The second time it happened I didn't have to uninstall the plugin, after a reload the sync completed.

astratto commented 2 years ago

I'm having the same issue. It sync'ed correctly until yesterday. I've tried uninstalling the plugin, reconnecting the plugin and restarting Obsidian, same problem.

Looking at the console, it seems stuck in a loop with a call to GET "https://readwise.io/api/get_export_status?exportStatusId=..."

image

TristanH commented 2 years ago

Hey all! Just wanted to confirm I'm still looking into this.

@cvh-obsi -- unfortunately I don't believe I can see your email if you sent it through github -- github hides it

@kometenstaub -- would also greatly benefit from your email address (feel free to send to me at tristan@readwise.io) to debug this -- thanks :)

@astratto I was actually able to find your Readwise account based on your name and I can confirm that it was just a slow sync. The sync finished after 30 minutes, so if you had let it run that long then it would have finished properly (although potentially the install/reinstall could have messed things up). Of course, our standard for sync speed is to be near ~instant, so my apologies! I just deployed some fixes to make it hopefully run much faster,

cvh-obsi commented 2 years ago

Hi My last trials happened correctly Did you receive the email I sent where I mentioned my Obsidian account email @.) ? Le 19 août 2021 à 18:28 +0200, TristanH @.>, a écrit :

Hey all! Just wanted to confirm I'm still looking into this. @cvh-obsi -- unfortunately I don't believe I can see your email if you sent it through github -- github hides it @kometenstaub -- would also greatly benefit from your email address (feel free to send to me at @.***) to debug this -- thanks :) @astratto I was actually able to find your Readwise account based on your name and I can confirm that it was just a slow sync. The sync finished after 30 minutes, so if you had let it run that long then it would have finished properly (although potentially the install/reinstall could have messed things up). Of course, our standard for sync speed is to be near ~instant, so my apologies! I just deployed some fixes to make it hopefully run much faster, — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

kometenstaub commented 2 years ago

@TristanH Which email address do you need? Here you said the one associated with the obsidian account. Don't you need the email address I use for readwise?

TristanH commented 2 years ago

Oops, sorry @kometenstaub , I meant the one associated with your Readwise account! Thanks for the correction.

tadeoos commented 2 years ago

@kometenstaub @cvh-obsi @astratto have you experienced this behavior recently (last 2 weeks?)

kometenstaub commented 2 years ago

No, I didn't have any issues since then.

cvh-obsi commented 2 years ago

Me neither :-)

Envoyé de mon iPhone

Le 14 sept. 2021 à 15:05, Tadek Teleżyński @.***> a écrit :

 @kometenstaub @cvh-obsi have you experienced this behavior recently (last 2 weeks?)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

nicknisi commented 2 years ago

I have also started experiencing this issue today. It looks like it does eventually stop on its own, but takes a while. Each time it makes a request to the server, it comes back as PENDING until it eventually doesn't, so it seems like it's working, the only strange thing is the continuous "Building Export" message.

nikbrunner commented 2 years ago

I am having the same issue.

I hope this gets fixed soon! :) ...otherwise the Plugin is unusable of course

image

tadeoos commented 2 years ago

@nikbrunner the Readwise Official plugin: didn't get token data, retrying (attempt 1) is not an error, it just depends on the speed the browser will open with, it means we got your token in the second attempt.

What is worrying me in your screenshot is the SyntaxErrors I see — I assume you are on the latest plugin version, do you know if they are coming from our plugin or from a different one (easy way to find out would be to uninstalling readwise plugin and checking if they are still in console)?

Re: long readwise: building export (cc @nicknisi): this indicates that an export task has been scheduled and it's starting. It can sometimes take longer due to our queues having more tasks in them or if a deployment of the app is happening.

@nikbrunner if you initiate a sync now do you still get "last sync failed" message?

nikbrunner commented 2 years ago

@tadeoos Thank you for your quick reply. I have got these Syntax Errors long before installing Readwise. I have not tried to remove them until now, since they seemingly had no negative effect on my usage of Obsidian. I was able to remove one of the errors by uninstalling the Git Plugin for Obsidian, but the other I am not sure about where it is coming from

Obsidian itself is up to date and I updated all plugins

Partially good news is, that during the process of restarting Obsidian multiple times now, and because the Readwise Plugin syncs on Obsidian Boot I noticed that it did sync something. Some highlights from my Kindle did go through, but not all notes to these highlights. And yes these are shown on the Readwise Website. So they should be available.

And to your question. If I now press the "Sync now" Button, it seems successfull and I get a "Synced" message besides the Button, but like I said It seems not all content is synced

Update

I now deleted my Readwise folder and initiated a sync again and now all content seems to have synced. It seems to be working now. 😃

tadeoos commented 2 years ago

@nikbrunner thanks for a quick reply! Glad that those syntax errors are not from us. Very glad to hear it is working now! Yes — when in doubt deleting the Readwise folder will trigger full fresh sync :)