readymade-ui / starter

Starter code for building a site with Readymade
8 stars 2 forks source link

Any issues that you encountered with skate ssr? #4

Open trusktr opened 4 years ago

trusktr commented 4 years ago

Curious to know what limitations you encountered with Skate SSR. I'd like to circle back to SSR at some point with lume/element.

steveblue commented 4 years ago

The @skatejs/ssr package could be falling out of maintenance, last publish was 2 years ago.

There was a slight hiccup when pairing the ssr package with Readymade.

The ssr package injects a call to a function called __ssr in the server side rendered template that is returned by the render() function. That function didn't exist or I looked at the implementation and said whatevs, so I had to postprocess the template. See here.

It's maybe a good time for someone to make an ESM equivalent that is framework agnostic, but for now it does the job.

The package is fast, I'll give it that. Looking into the source it seems there are opportunities to make how it walks the DOM more performant.

trusktr commented 4 years ago

render()

Ah, I see, it was expecting a SkateJS-specific method. So you did your own thing there.