Fix VoiceHandler memory access out of bounds on WebGL

readyplayerme / rpm-unity-sdk-core

This Module contains all the core functionality required for using Ready Player Me avatars in Unity, including avatar loading and creation

MIT License

97 stars 33 forks source link

Fix VoiceHandler memory access out of bounds on WebGL #324

Open mennetorelli opened 2 weeks ago

mennetorelli commented 2 weeks ago

Description

This should fix issue #323, where for some AudioClip lengths the GetAmplitude method tried to read data from the clip even if the remaining samples were 0.

How to Test

add VoiceHandler component on an avatar
set build target to webGL and run the built application
let the AudioSource referenced by the VoiceHandler reproduce AudioClips with various lengths

Checklist

[ ] Tests written or updated for the changes.
[ ] Documentation is updated.
[ ] Changelog is updated.

baaskoen commented 3 days ago

@mennetorelli Thanks for yor effort! I tested this locally, and I noticed that there is still a small percentage to error, but I cant reliably reproduce it (it errors now like 1 in 100 audio files).

But this is already a huge improvement.