readyplayerme / rpm-unity-sdk-webview

WebView helps you display an in-engine browser that helps you load RPM website where you can create avatars and receive avatar URL at the end of the process.
zlib License
13 stars 7 forks source link

[SDK-697] Feature/remove permission override #26

Closed HarrisonHough closed 4 months ago

HarrisonHough commented 5 months ago

SDK-697

Description

Changes

Added

Updated

Removed

How to Test

Checklist

HarrisonHough commented 4 months ago

Overally looks good, but do we want this to be disabled by default? Or should we still add the macro to the unity, when project is imported? we don't know how many people don't need the permissions and how many do right?

It's a good question. Generally I would say that people would only need the permissions if targeting mobile AND they don't want to use the CAC. If they are targeting VR however (which includes mobile/android) then permissions need to be removed if they plan to release to the quest store. If we still wanted it enabled by default we can either:

  1. force add the symbol when the package is installed
  2. OR rework the symbol to do the opposite. EG RPM_DISABLE_WEBVIEW_PERMISSIONS so that by default it would be enabled (As there would be no symbol) then they just add it if they want to disable it.

The main problem I have with having permissions enabled by default is that it's forcing things that may not be need that can cause bugs, and could be overriding some of their own build post processors. However on the flipside if they do actually need the permissions for their app then of course being enabled by default would be useful