[3973954414] Added BlendShapes to the RenderLoader - Githubissues

readyplayerme / rpm-unreal-sdk

Ready Player Me Unreal SDK

Other

23 stars 9 forks source link

[3973954414] Added BlendShapes to the RenderLoader #2

Closed gadamyan closed 1 year ago

gadamyan commented 1 year ago

TICKETID

Description

Added BlendShapes to the RenderLoader
Refactored RenderLoader and timeout and canceling functionality
Extracted MorphTargetUtils for morph-target conversion to string
Removed UMG from the build settings
Changed the texture type from Texture to Texture2D
Removed LoadRender function from the ReadyPlayerMeComponent

Changes

Added

Added BlendShapes to the RenderLoader

Updated

Refactored code

Removed

Removed LoadRender function from the ReadyPlayerMeComponent

How to Test

An example needs to be added in the UnrealExamples repo

Checklist

[ ] Documentation is updated.
[ ] Changelog is updated.

gadamyan commented 1 year ago

Code looks fine, have you tested building for android with these changes? Asking mainly because of the removal of this UMG in build.cs. This might be fine now but in an early version I remember there was issues on certain platforms. Maybe it was also a 4.25 issue. I'll test once I setup android for 4.27

I added the UMG before because I was using the UAsyncTaskDownloadImage before, It was adding some limitations for us. I removed it and now I'm using the base request instead. It's always good to remove unneeded dependency.