readysettech / readyset

Readyset is a MySQL and Postgres wire-compatible caching layer that sits in front of existing databases to speed up queries and horizontally scale read throughput. Under the hood, ReadySet caches the results of cached select statements and incrementally updates these results over time as the underlying data changes.
https://readyset.io
Other
4.54k stars 125 forks source link

Enhance Snapshot Extend Recipe Warning #1295

Closed altmannmarcelo closed 4 months ago

altmannmarcelo commented 4 months ago

Description

In case we fail to Parse a DDL, we show the reason why, but we don't mention which table was erroring out:

2024-06-25T16:47:23.003371Z  WARN taking database snapshot: replicators::mysql_connector::snapshot: Error extending CREATE TABLE, table will not be used error=Error during RPC (extend_recipe (in readyset-client/src/controller/rpc.rs:49:26)): Table 'fks.c' is not being replicated by ReadySet
2024-06-25T16:47:23.006509Z  WARN taking database snapshot: replicators::mysql_connector::snapshot: Error extending CREATE TABLE, table will not be used error=Error during RPC (extend_recipe (in readyset-client/src/controller/rpc.rs:49:26)): Table 'fks.c' is not being replicated by ReadySet
2024-06-25T16:47:23.008861Z  WARN taking database snapshot: replicators::mysql_connector::snapshot: Error extending CREATE TABLE, table will not be used error=Error during RPC (extend_recipe (in readyset-client/src/controller/rpc.rs:49:26)): Table 'fks.c' is not being replicated by ReadySet

We should mention which table DDL we were trying to apply

Change in user-visible behavior

Requires documentation change