readysettech / readyset

Readyset is a MySQL and Postgres wire-compatible caching layer that sits in front of existing databases to speed up queries and horizontally scale read throughput. Under the hood, ReadySet caches the results of cached select statements and incrementally updates these results over time as the underlying data changes.
https://readyset.io
Other
4.54k stars 125 forks source link

readyset_query_log_total_cache_misses not being populated #1350

Open altmannmarcelo opened 3 months ago

altmannmarcelo commented 3 months ago

Description

Investigate why we are not incrementing readyset_query_log_total_cache_misses counter when we hit a cache miss.

Example of one deployment with two caches:

# TYPE readyset_server_view_query_result_miss counter
0  readyset_server_view_query_result_miss{upstream_db_type="mysql",deployment="readyset.db"} 72611

curl localhost:6034/metrics | grep readyset_query_log_total_cache_misses
# TYPE readyset_query_log_total_cache_misses counter
readyset_query_log_total_cache_misses{upstream_db_type="mysql",deployment="readyset.db",cache_name="q_c6b0f1eb50a321ad"} 0
readyset_query_log_total_cache_misses{upstream_db_type="mysql",deployment="readyset.db",cache_name="q_3695f4f81233b19a"} 0

Change in user-visible behavior

Requires documentation change