search

readysettech / readyset

Readyset is a MySQL and Postgres wire-compatible caching layer that sits in front of existing databases to speed up queries and horizontally scale read throughput. Under the hood, ReadySet caches the results of cached select statements and incrementally updates these results over time as the underlying data changes.
https://readyset.io
Other
4.54k stars 126 forks source link

Unify --allow-unsupported-set and --unsupported-set-mode #1354

Closed altmannmarcelo closed 1 month ago

altmannmarcelo commented 3 months ago

Description

Today we have --unsupported-set-mode that allows for two values, Error and Proxy. but we also have --allow-unsupported-set as a dedicated variable. Those two variables all control what we set in:

pub enum UnsupportedSetMode {
    /// Return an error to the client (the default)
    Error,
    /// Proxy all subsequent statements to the upstream
    Proxy,
    /// Allow all unsupported set statements
    Allow,
}

We should unify them by adding allow as one option to --unsupported-set-mode

Change in user-visible behavior

Requires documentation change