readysettech / readyset

Readyset is a MySQL and Postgres wire-compatible caching layer that sits in front of existing databases to speed up queries and horizontally scale read throughput. Under the hood, ReadySet caches the results of cached select statements and incrementally updates these results over time as the underlying data changes.
https://readyset.io
Other
4.54k stars 125 forks source link

Merge `--allow-unsupported-set` into `--unsupported-set-mode` #1380

Open jasobrown-rs opened 1 month ago

jasobrown-rs commented 1 month ago

Description

--allow-unsupported-set was added to allow readyset is naively ignore any SET commands it could not process. About a year later, we introduced the --unsupported-set-mode flag and enum. One of the modes available is Allow, that mapped directly onto the existing --allow-unsupported-set.

Confusingly, we did not remove the older flag, and we did not allow setting --unsupported-set-mode allow. Let's reduce our cli flag burden and just merge the two behaviors, into the way it looks like it was intended to be.

jasobrown-rs commented 1 month ago

Duplicate of REA-4673

jasobrown-rs commented 1 month ago

Duplicate of #1354