Closed denbeigh2000 closed 4 years ago
Cool bot!
Awesome keep me posted on Docker progress. I'm currently going deep with Docker and Kubernetes right now for DevOps job.
Get Outlook for iOShttps://aka.ms/o0ukef
From: Denbeigh Stevens notifications@github.com Sent: Wednesday, March 11, 2020 12:00:09 AM To: reaganmcf/discord-stock-bot discord-stock-bot@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [reaganmcf/discord-stock-bot] Add support to run in docker (#11)
This adds some basic support for building and running in docker, which I'm using to run my own deployment. I've also added a couple of lines on building and invoking in the README.
You can view, comment on, or merge this pull request online at:
https://github.com/reaganmcf/discord-stock-bot/pull/11https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freaganmcf%2Fdiscord-stock-bot%2Fpull%2F11&data=02%7C01%7Cs.keita%40umiami.edu%7C0995b306deba4373057108d7c570b142%7C2a144b72f23942d48c0e6f0f17c48e33%7C0%7C0%7C637194960117606292&sdata=%2B0kB%2FbsEBu2%2F0vUS%2BCreLXXK%2FXPkGlesozR4jZLUtfY%3D&reserved=0
Commit Summary
File Changes
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freaganmcf%2Fdiscord-stock-bot%2Fpull%2F11%3Femail_source%3Dnotifications%26email_token%3DAASTWKDSJHM5YNBVTAQHCQDRG4EETA5CNFSM4LFM62DKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IUCX4TA&data=02%7C01%7Cs.keita%40umiami.edu%7C0995b306deba4373057108d7c570b142%7C2a144b72f23942d48c0e6f0f17c48e33%7C0%7C0%7C637194960117636271&sdata=II36tRtF13%2FbeRBWdbFvypkUSI9zL98BchY4gRzFZT4%3D&reserved=0, or unsubscribehttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAASTWKDPBKADVAD7XYPXG3DRG4EETANCNFSM4LFM62DA&data=02%7C01%7Cs.keita%40umiami.edu%7C0995b306deba4373057108d7c570b142%7C2a144b72f23942d48c0e6f0f17c48e33%7C0%7C0%7C637194960117646265&sdata=WXvzseXDresN99xRTaxigvvsG%2BOfJpHSmtTuafj6Nsc%3D&reserved=0.
There shouldn't be anything else you need to do, I've built and deployed my own container using this revision.
k8s is not in my scope here, but no ports are exposed so it should be pretty trivial for you to write a chart for it if you'd like to.
Sorry for being late on this, looks good to me! Thanks for contributing 😀
This adds some basic support for building and running in docker, which I'm using to run my own deployment. I've also added a couple of lines on building and invoking in the README.