search

reagent-project / reagent-forms

Bootstrap form components for Reagent
339 stars 78 forks source link

:disabled should support functions #125

Closed smogg closed 6 years ago

smogg commented 6 years ago

:disabled should support boolean value or a function (similarly to :visible? - see #59)

This PR also adds (previously missing) support for :disabled in either of the two forms to the following components:

Still unsupported elements:

I'm not sure how to handle those yet. The structure is more complicated - I could use clojure.walk but I'm trying to think of a simpler solution without additional dependency. I'll revisit when I have time again.

yogthos commented 6 years ago

The pr looks good to me. Do you want me to merge the current version in, or wait until you figure out an approach for option and button elements?

smogg commented 6 years ago

I think we are good to go with merging what's already pushed. I'm gonna try to submit another one over the weekend